[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 24 19:36:27 PST 2024


================
@@ -336,6 +338,9 @@ class LLVM_LIBRARY_VISIBILITY Generic_GCC : public ToolChain {
       const llvm::opt::ArgList &DriverArgs,
       llvm::opt::ArgStringList &CC1Args) const override;
 
+  void AddSYCLIncludeArgs(const llvm::opt::ArgList &DriverArgs,
----------------
MaskRay wrote:

since this is new function. name it `add...` instead of `Add...`.

Yes, clangDriver naming is very inconsistent, but we try to make them consistent for new functions.

https://github.com/llvm/llvm-project/pull/117268


More information about the llvm-commits mailing list