[llvm] [Telemetry] Add missing virtual destructors (PR #121015)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 23 16:29:06 PST 2024


https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/121015

Fixes warnings after #121003.


>From cb1f0979272a59bd645bf270607aa229a14aa7a8 Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at google.com>
Date: Mon, 23 Dec 2024 16:28:53 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
 =?UTF-8?q?l=20version?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Created using spr 1.3.4
---
 llvm/include/llvm/Telemetry/Telemetry.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/llvm/include/llvm/Telemetry/Telemetry.h b/llvm/include/llvm/Telemetry/Telemetry.h
index bbf0ac84d667ac..344a49df5cbf0f 100644
--- a/llvm/include/llvm/Telemetry/Telemetry.h
+++ b/llvm/include/llvm/Telemetry/Telemetry.h
@@ -30,6 +30,8 @@ namespace telemetry {
 
 class Serializer {
 public:
+  virtual ~Serializer() = default;
+
   virtual Error init() = 0;
   virtual void write(StringRef KeyName, bool Value) = 0;
   virtual void write(StringRef KeyName, StringRef Value) = 0;
@@ -62,6 +64,8 @@ class Serializer {
 /// This struct can be extended as needed to add additional configuration
 /// points specific to a vendor's implementation.
 struct Config {
+  virtual ~Config() = default;
+
   // If true, telemetry will be enabled.
   const bool EnableTelemetry;
   Config(bool E) : EnableTelemetry(E) {}
@@ -132,6 +136,8 @@ class Destination {
 /// monitored and transmitting the data elsewhere.
 class Manager {
 public:
+  virtual ~Manager() = default;
+
   // Optional callback for subclasses to perform additional tasks before
   // dispatching to Destinations.
   virtual Error preDispatch(TelemetryInfo *Entry) = 0;



More information about the llvm-commits mailing list