[llvm] [ADT] Add a unittest for the ScopedHashTable class (PR #120183)

Sat Dec 21 17:40:59 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `llvm` at step 3 "clean-build-dir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/1749

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 3 (clean-build-dir) failure: Delete failed. (failure) (timed out)
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
...
504.841 [655/50/334] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/ImmutableSetTest.cpp.o
504.985 [654/50/335] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/Interleave.cpp.o
505.135 [653/50/336] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/IntervalMapTest.cpp.o
505.266 [652/50/337] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/IntervalTreeTest.cpp.o
505.410 [651/50/338] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/IteratorTest.cpp.o
505.571 [650/50/339] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/LazyAtomicPointerTest.cpp.o
506.009 [649/50/340] Building CXX object tools/clang/unittests/Interpreter/CMakeFiles/ClangReplInterpreterTests.dir/IncrementalCompilerBuilderTest.cpp.o
506.106 [648/50/341] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/PackedVectorTest.cpp.o
506.279 [647/50/342] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/RewriteBufferTest.cpp.o
506.715 [646/50/343] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/ScopedHashTableTest.cpp.o
FAILED: unittests/ADT/CMakeFiles/ADTTests.dir/ScopedHashTableTest.cpp.o 
/usr/local/clang-17.0.2/bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LARGE_FILE_API -D_XOPEN_SOURCE=700 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/unittests/ADT -I/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT -I/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/include -I/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/include -I/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/third-party/unittest/googletest/include -I/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/third-party/unittest/googlemock/include -mcmodel=large -fPIC -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD -MT unittests/ADT/CMakeFiles/ADTTests.dir/ScopedHashTableTest.cpp.o -MF unittests/ADT/CMakeFiles/ADTTests.dir/ScopedHashTableTest.cpp.o.d -o unittests/ADT/CMakeFiles/ADTTests.dir/ScopedHashTableTest.cpp.o -c /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT/ScopedHashTableTest.cpp
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT/ScopedHashTableTest.cpp:41:20: error: 'ScopedHashTableScope' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
   41 |   [[maybe_unused]] ScopedHashTableScope varScope(symbolTable);
      |                    ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/include/llvm/ADT/ScopedHashTable.h:85:7: note: add a deduction guide to suppress this warning
   85 | class ScopedHashTableScope {
      |       ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT/ScopedHashTableTest.cpp:46:20: error: 'ScopedHashTableScope' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
   46 |   [[maybe_unused]] ScopedHashTableScope varScope(symbolTable);
      |                    ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/include/llvm/ADT/ScopedHashTable.h:85:7: note: add a deduction guide to suppress this warning
   85 | class ScopedHashTableScope {
      |       ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT/ScopedHashTableTest.cpp:52:20: error: 'ScopedHashTableScope' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
   52 |   [[maybe_unused]] ScopedHashTableScope varScope(symbolTable);
      |                    ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/include/llvm/ADT/ScopedHashTable.h:85:7: note: add a deduction guide to suppress this warning
   85 | class ScopedHashTableScope {
      |       ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT/ScopedHashTableTest.cpp:53:20: error: 'ScopedHashTableScope' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
   53 |   [[maybe_unused]] ScopedHashTableScope varScope2(symbolTable);
      |                    ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/include/llvm/ADT/ScopedHashTable.h:85:7: note: add a deduction guide to suppress this warning
   85 | class ScopedHashTableScope {
      |       ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT/ScopedHashTableTest.cpp:54:20: error: 'ScopedHashTableScope' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
   54 |   [[maybe_unused]] ScopedHashTableScope varScope3(symbolTable);
      |                    ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/include/llvm/ADT/ScopedHashTable.h:85:7: note: add a deduction guide to suppress this warning
   85 | class ScopedHashTableScope {
      |       ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT/ScopedHashTableTest.cpp:61:22: error: 'ScopedHashTableScope' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
   61 |     [[maybe_unused]] ScopedHashTableScope varScope(symbolTable);
      |                      ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/include/llvm/ADT/ScopedHashTable.h:85:7: note: add a deduction guide to suppress this warning
   85 | class ScopedHashTableScope {
      |       ^
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/unittests/ADT/ScopedHashTableTest.cpp:68:20: error: 'ScopedHashTableScope' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]

```

</details>

https://github.com/llvm/llvm-project/pull/120183