[lld] [lld][MachO] Fix symbol insertion in `transplantSymbolsAtOffset` (PR #120737)

[Björn Pettersson via llvm-commits]

bjope wrote:

Nice idea with the assert. Adding
`assert(llvm::is_sorted(toIsec->symbols) && "Symbols should still be sorted at exit.");
`
at end of transplantSymbolsAtOffset seem to result in assertion failure for the `lld/test/MachO/symtab.s`.

So that might be enough, considering that there already is a test case that would trigger such an assert.

https://github.com/llvm/llvm-project/pull/120737