[llvm] [LV] Prevent query the computeCost() when VF=1 in emitInvalidCostRemarks(). (PR #117288)

David Sherwood via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 01:58:00 PST 2024


================
@@ -0,0 +1,65 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -mtriple=riscv64 -mattr=+v -p loop-vectorize -pass-remarks-analysis=loop-vectorize -S | FileCheck %s
----------------
david-arm wrote:

This doesn't feel quite right, since you're passing `-pass-remarks-analysis=loop-vectorize` but not testing the output. Given this test is about remarks, I think we should check the output and also ensure we don't see the VF=1 case.

https://github.com/llvm/llvm-project/pull/117288


More information about the llvm-commits mailing list