[llvm] [NFC][AArch64][SVE] Rename variables in partial reduction lowering functions (PR #120589)
Sander de Smalen via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 20 00:52:28 PST 2024
================
@@ -21739,73 +21739,71 @@ SDValue tryLowerPartialReductionToDot(SDNode *N,
SDLoc DL(N);
// The narrower of the two operands. Used as the accumulator
- auto NarrowOp = N->getOperand(1);
- auto MulOp = N->getOperand(2);
- if (MulOp->getOpcode() != ISD::MUL)
+ auto A = N->getOperand(1);
+ auto B = N->getOperand(2);
+ if (B->getOpcode() != ISD::MUL)
return SDValue();
- auto ExtA = MulOp->getOperand(0);
- auto ExtB = MulOp->getOperand(1);
+ auto ExtMulOp1 = B->getOperand(0);
+ auto ExtMulOp2 = B->getOperand(1);
- if (!ISD::isExtOpcode(ExtA->getOpcode()) ||
- !ISD::isExtOpcode(ExtB->getOpcode()))
+ if (!ISD::isExtOpcode(ExtMulOp1->getOpcode()) ||
+ !ISD::isExtOpcode(ExtMulOp2->getOpcode()))
return SDValue();
- bool AIsSigned = ExtA->getOpcode() == ISD::SIGN_EXTEND;
- bool BIsSigned = ExtB->getOpcode() == ISD::SIGN_EXTEND;
+ bool MulOp1IsSigned = ExtMulOp1->getOpcode() == ISD::SIGN_EXTEND;
+ bool MulOp2IsSigned = ExtMulOp2->getOpcode() == ISD::SIGN_EXTEND;
- auto A = ExtA->getOperand(0);
- auto B = ExtB->getOperand(0);
- if (A.getValueType() != B.getValueType())
+ auto MulOp1 = ExtMulOp1->getOperand(0);
+ auto MulOp2 = ExtMulOp2->getOperand(0);
+ if (MulOp1.getValueType() != MulOp2.getValueType())
return SDValue();
- EVT ReducedType = N->getValueType(0);
- EVT MulSrcType = A.getValueType();
+ EVT AVT = N->getValueType(0);
----------------
sdesmalen-arm wrote:
Isn't this the result type of the partial reduction itself? If so, I would just name this `ReducedVT`.
https://github.com/llvm/llvm-project/pull/120589
More information about the llvm-commits
mailing list