[llvm] [SelectionDAG] Split SDNode::use_iterator into SDNode::user_iterator and sd_use_iterator. (PR #120531)

[Craig Topper via llvm-commits]

================
@@ -13780,11 +13777,10 @@ SDValue DAGCombiner::foldSextSetcc(SDNode *N) {
 
         // Non-chain users of this value must either be the setcc in this
         // sequence or extends that can be folded into the new {z/s}ext-load.
-        for (SDNode::use_iterator UI = V->use_begin(), UE = V->use_end();
-             UI != UE; ++UI) {
+        for (SDUse &Use : V->uses()) {
----------------
topperc wrote:

Even without next/prev there are 3 pieces of information not two. The SDNode * being used, the result number being used, and the SDNode * of the user instruction.

https://github.com/llvm/llvm-project/pull/120531