[llvm] [llvm-objdump] Remove some unneeded headers. (PR #120541)

via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 03:08:52 PST 2024


cabbaken wrote:

Almost all headers I removed are included by the relative header. For example, StringSet is included by llvm-objdump.h.
It’s the first time I submit my patch to community, sorry if I did something wrong🥺.

Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: James Henderson ***@***.***>
Sent: Thursday, December 19, 2024 5:41:21 PM
To: llvm/llvm-project ***@***.***>
Cc: Cabbaken ***@***.***>; Author ***@***.***>
Subject: Re: [llvm/llvm-project] [llvm-objdump] Remove some unneeded headers. (PR #120541)


@jh7370 commented on this pull request.

Could you clarify how you went about identifying which headers are unneeded, please? I note for example that StringSet is used in llvm-objdump.cpp.

—
Reply to this email directly, view it on GitHub<https://github.com/llvm/llvm-project/pull/120541#pullrequestreview-2513855090>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AO43NCNQSFAVAHAF2XE4W5T2GKIEDAVCNFSM6AAAAABT4RAMT2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJTHA2TKMBZGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>


https://github.com/llvm/llvm-project/pull/120541


More information about the llvm-commits mailing list