[llvm] [llvm-readelf] Update outdated URL (PR #120498)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 19 02:55:48 PST 2024
jh7370 wrote:
> Hi @jh7370, thanks for the response! Would you recommend that I leave it as is or point to the general link of the mailing list instead (https://groups.google.com/g/generic-abi).
As the point of the link is to provide people with a reference point for the registered machine constants, I'd be inclined to include both the link from my previous comment and the generic mailing list link, with some updates to the comment. Something along the lines that "At the time of writing, the list of registered machine architectures is at <link>. Please refer to <generic ABI mailing list> for any further updates."
> Also I'm very new to this so I'm not sure why tests are failing and what to do in this scenario. Will merging my branch on the latest version fix it?
Taking a quick look at the failures shows that these tests aren't anything to do with your change (which was obvious anyway, since you've only touched a comment). This means you can safely ignore them. They'll be broken in `main` at the time you created your branch and will have either been fixed by the time this gets merged, or will be fixed in the future. Either way, you don't need to do anything special. If you're fussed, you could try making a merge commit from main into your branch and pushing that to see if the test is fixed.
https://github.com/llvm/llvm-project/pull/120498
More information about the llvm-commits
mailing list