[llvm] [IA][RISCV] Support VP intrinsics in InterleavedAccessPass (PR #120490)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 18 15:13:54 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->
:warning: undef deprecator found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 8272b6bd6146aab973ff7018ad642b99fde00904 07e0a5ca0b8e5f5bf94ff0d9a7b3366ff51778d3 llvm/test/CodeGen/RISCV/rvv/scalable-vectors-interleaved-access.ll llvm/test/CodeGen/RISCV/rvv/scalable-vectors-strided-interleave-load-32.ll llvm/test/CodeGen/RISCV/rvv/scalable-vectors-strided-interleave-load-64.ll llvm/include/llvm/CodeGen/TargetLowering.h llvm/lib/CodeGen/InterleavedAccessPass.cpp llvm/lib/Target/RISCV/RISCVISelLowering.cpp llvm/lib/Target/RISCV/RISCVISelLowering.h
``````````
</details>
The following files introduce new uses of undef:
- llvm/lib/Target/RISCV/RISCVISelLowering.cpp
- llvm/test/CodeGen/RISCV/rvv/scalable-vectors-interleaved-access.ll
- llvm/test/CodeGen/RISCV/rvv/scalable-vectors-strided-interleave-load-32.ll
- llvm/test/CodeGen/RISCV/rvv/scalable-vectors-strided-interleave-load-64.ll
[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.
In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.
For example, this is considered a bad practice:
```llvm
define void @fn() {
...
br i1 undef, ...
}
```
Please use the following instead:
```llvm
define void @fn(i1 %cond) {
...
br i1 %cond, ...
}
```
Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.
https://github.com/llvm/llvm-project/pull/120490
More information about the llvm-commits
mailing list