[compiler-rt] [win/asan] Don't intercept memset etc. in ntdll (PR #120397)

Zack Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 06:13:00 PST 2024


zacklj89 wrote:

@zmodem firstly, thanks for the review on https://github.com/llvm/llvm-project/pull/120110 and tagging here! I work on ASan at MS, and issues/conversations like these are helpful.

I think it's a reasonable implementation and tradeoff. My initial impression was that there are programs that use `ntdll` as their sole C runtime and thus would lose significant coverage by omitting these functions as candidates for interception. However, there's nothing stopping further changes to the EH machinery / ntdll stack which aggravates interception again.

If this is preferred over https://github.com/llvm/llvm-project/pull/120110, let me know.

https://github.com/llvm/llvm-project/pull/120397


More information about the llvm-commits mailing list