[llvm] [SPIR-V] Overhaul module analysis to improve translation speed and simplify the underlying logics (PR #120415)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 3ed2a81358e11a582eb5cc3edf711447767036e6 2118902350ed1d0804c7440058ef1d8ec8bfa9df --extensions cpp,h -- llvm/lib/Target/SPIRV/SPIRVAsmPrinter.cpp llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h llvm/lib/Target/SPIRV/SPIRVInstrInfo.cpp llvm/lib/Target/SPIRV/SPIRVInstrInfo.h llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.h llvm/lib/Target/SPIRV/SPIRVPreLegalizer.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h b/llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h
index 936cfc291c..ec66a72299 100644
--- a/llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h
+++ b/llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h
@@ -90,8 +90,7 @@ class SPIRVGlobalRegistry {
   DenseMap<Value *, CallInst *> AssignPtrTypeInstr;
 
   // Maps OpVariable and OpFunction-related v-regs to its LLVM IR definition.
-  DenseMap<std::pair<const MachineFunction *, Register>, const Value *>
-      Reg2GO;
+  DenseMap<std::pair<const MachineFunction *, Register>, const Value *> Reg2GO;
 
   // Add a new OpTypeXXX instruction without checking for duplicates.
   SPIRVType *createSPIRVType(const Type *Type, MachineIRBuilder &MIRBuilder,
diff --git a/llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp b/llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp
index 74af2dfb7a..258e342189 100644
--- a/llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp
@@ -430,7 +430,8 @@ void SPIRVModuleAnalysis::visitDecl(
   if (TII->isSpecConstantInstr(MI)) {
     GReg = Register::index2VirtReg(MAI.getNextID());
     MAI.MS[SPIRV::MB_TypeConstVars].push_back(&MI);
-  } else if (Opcode == SPIRV::OpFunction || Opcode == SPIRV::OpFunctionParameter) {
+  } else if (Opcode == SPIRV::OpFunction ||
+             Opcode == SPIRV::OpFunctionParameter) {
     const Value *GObj = GR->getGlobalObject(MF, MI.getOperand(0).getReg());
     assert(GObj && "Unregistered global definition");
     const Function *F = dyn_cast<Function>(GObj);
@@ -2080,8 +2081,8 @@ void SPIRVModuleAnalysis::getAnalysisUsage(AnalysisUsage &AU) const {
   AU.addRequired<MachineModuleInfoWrapperPass>();
 }
 /*
-static void debugPrint(const Module &M, SPIRVGlobalRegistry *GR, const SPIRVInstrInfo &TII,
-                           MachineModuleInfo *MMI, const SPIRVSubtarget &ST,
+static void debugPrint(const Module &M, SPIRVGlobalRegistry *GR, const
+SPIRVInstrInfo &TII, MachineModuleInfo *MMI, const SPIRVSubtarget &ST,
                            SPIRV::ModuleAnalysisInfo &MAI) {
   for (auto F = M.begin(), E = M.end(); F != E; ++F) {
     MachineFunction *MF = MMI->getMachineFunction(*F);
@@ -2106,25 +2107,25 @@ bool SPIRVModuleAnalysis::runOnModule(Module &M) {
 
   addMBBNames(M, *TII, MMI, *ST, MAI);
   addDecorations(M, *TII, MMI, *ST, MAI);
-/*
-  // -- debug-print ---
-  debugPrint(M, GR, *TII, MMI, *ST, MAI);
-*/
+  /*
+    // -- debug-print ---
+    debugPrint(M, GR, *TII, MMI, *ST, MAI);
+  */
   collectReqs(M, MAI, MMI, *ST);
 
   // Process type/const/global var/func decl instructions, number their
   // destination registers from 0 to N, collect Extensions and Capabilities.
-  //processDefInstrs(M);
+  // processDefInstrs(M);
   collectDeclarations(M);
 
   // Number rest of registers from N+1 onwards.
   numberRegistersGlobally(M);
 
-/*
-  // Update references to OpFunction instructions to use Global Registers
-  if (GR->hasConstFunPtr())
-    collectFuncPtrs();
-*/
+  /*
+    // Update references to OpFunction instructions to use Global Registers
+    if (GR->hasConstFunPtr())
+      collectFuncPtrs();
+  */
 
   // Collect OpName, OpEntryPoint, OpDecorate etc, process other instructions.
   processOtherInstrs(M);

``````````

</details>


https://github.com/llvm/llvm-project/pull/120415