[llvm] [Github] Add LLVM Premerge Checks to the watchlist (PR #120230)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 14:48:03 PST 2024


Nathan =?utf-8?q?Gauër?= <brioche at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/120230 at github.com>


https://github.com/boomanaiden154 approved this pull request.

Tested manually since we don't have any automated testing:
```
[JobMetrics(job_name='Check code formatting', queue_time=6, run_time=172, status=1, created_at_ns=1734474477000000000, workflow_id=12382528649), JobMetrics(job_name='LLVM Premerge Checks', queue_time=667, run_time=1013, status=1, created_at_ns=1734472175000000000, workflow_id=12382027516)]
Fake uploaded 2 metrics
[JobMetrics(job_name='Check code formatting', queue_time=6, run_time=172, status=1, created_at_ns=1734474605000000000, workflow_id=12382556504), JobMetrics(job_name='Check code formatting', queue_time=5, run_time=228, status=1, created_at_ns=1734474504000000000, workflow_id=12382535076)]
Fake uploaded 2 metrics
No metrics found to upload.
No metrics found to upload.
[JobMetrics(job_name='Check code formatting', queue_time=6, run_time=178, status=1, created_at_ns=1734474704000000000, workflow_id=12382576218)]
Fake uploaded 1 metrics
[JobMetrics(job_name='Check code formatting', queue_time=6, run_time=176, status=1, created_at_ns=1734474735000000000, workflow_id=12382582860)]
Fake uploaded 1 metrics
[JobMetrics(job_name='Check code formatting', queue_time=7, run_time=170, status=0, created_at_ns=1734474813000000000, workflow_id=12382598716), JobMetrics(job_name='Check code formatting', queue_time=6, run_time=181, status=1, created_at_ns=1734474789000000000, workflow_id=12382593396)]
Fake uploaded 2 metrics
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
[JobMetrics(job_name='Check code formatting', queue_time=5, run_time=186, status=1, created_at_ns=1734475015000000000, workflow_id=12382643443)]
Fake uploaded 1 metrics
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
[JobMetrics(job_name='Check code formatting', queue_time=7, run_time=184, status=1, created_at_ns=1734475208000000000, workflow_id=12382681715)]
Fake uploaded 1 metrics
[JobMetrics(job_name='LLVM Premerge Checks', queue_time=5, run_time=1801, status=0, created_at_ns=1734473648000000000, workflow_id=12382347323)]
Fake uploaded 1 metrics
```

Seems like everything is working, so LGTM. We'll have to modify the dashboard to add everything. To get this deployed we might also need to delete the pod to force it to pull the new container version. Theoretically we should always pull the container when recreating the pod, but I'm not sure if it's explicitly setup that way.

https://github.com/llvm/llvm-project/pull/120230


More information about the llvm-commits mailing list