[llvm] [NVPTX] Prefer ValueType when defining DAG patterns (NFC) (PR #120161)

Alex MacLean via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 12:51:22 PST 2024


================
@@ -3129,279 +3129,279 @@ foreach ta = [v2f16, v2bf16, v2i16, v4i8, i32] in {
 // and then cvt to floating-point.
 
 // sint -> f16
-def : Pat<(f16 (sint_to_fp Int1Regs:$a)),
+def : Pat<(f16 (sint_to_fp i1:$a)),
           (CVT_f16_s32 (SELP_s32ii -1, 0, Int1Regs:$a), CvtRN)>;
----------------
AlexMaclean wrote:

I prioritized the LHS  of `Pat`s but did some of the RHS in some cases when it was trivial. I think it would be good to update all the RHS as well but I'd prefer to land this batch first and follow up with those later on assuming no issues arise from this.

https://github.com/llvm/llvm-project/pull/120161


More information about the llvm-commits mailing list