[llvm] [LoopVectorize] Enable more early exit vectorisation tests (PR #117008)
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 17 08:59:45 PST 2024
================
@@ -10177,13 +10201,32 @@ bool LoopVectorizePass::processLoop(Loop *L) {
return false;
}
- if (LVL.hasUncountableEarlyExit() && !EnableEarlyExitVectorization) {
- reportVectorizationFailure("Auto-vectorization of loops with uncountable "
- "early exit is not enabled",
- "Auto-vectorization of loops with uncountable "
- "early exit is not enabled",
- "UncountableEarlyExitLoopsDisabled", ORE, L);
- return false;
+ if (LVL.hasUncountableEarlyExit()) {
+ if (!EnableEarlyExitVectorization) {
+ reportVectorizationFailure("Auto-vectorization of loops with uncountable "
+ "early exit is not enabled",
+ "UncountableEarlyExitLoopsDisabled", ORE, L);
+ return false;
+ }
+
+ // In addUsersInExitBlocks we already bail out if there is an outside use
+ // of a loop-defined variable, but it ignores induction variables which are
+ // handled by InnerLoopVectorizer::fixupIVUsers. We need to bail out if we
+ // encounter induction variables too otherwise fixupIVUsers will crash.
+ for (BasicBlock *BB : L->blocks()) {
+ for (Instruction &I : *BB) {
+ for (User *U : I.users()) {
----------------
fhahn wrote:
Do you have any concerns regarding https://github.com/llvm/llvm-project/pull/120260 or will the future patches rely on the IR based checks?
It is also possible to share multiple stacked PR to give a preview of what changes are in the pipeline (one option is to have a PR just include all commits or do stacked PRs via user branches https://discourse.llvm.org/t/update-on-github-pull-requests/71540/146?u=fhahn)
https://github.com/llvm/llvm-project/pull/117008
More information about the llvm-commits
mailing list