[llvm] [llvm]Add a simple Telemetry framework (PR #102323)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 17 01:40:39 PST 2024
================
@@ -27,14 +27,14 @@ namespace telemetry {
class Serializer {
public:
- virtual llvm::Error init() = 0;
+ virtual Error init() = 0;
virtual void write(StringRef KeyName, bool Value) = 0;
virtual void write(StringRef KeyName, int Value) = 0;
- virtual void write(StringRef KeyName, size_t Value) = 0;
+ virtual void write(StringRef KeyName, unsigned long long Value) = 0;
----------------
jh7370 wrote:
This is a slightly weird subset of types that you've provided overloads for. Could you explain why you've chosen these three specifically and no other fundamental types?
https://github.com/llvm/llvm-project/pull/102323
More information about the llvm-commits
mailing list