[llvm] [NVPTX] Prefer ValueType when defining DAG patterns (NFC) (PR #120161)

[Artem Belevich via llvm-commits]

https://github.com/Artem-B approved this pull request.

LGTM in principle.

I'm not 100% convinced that it's a NFC change. Will matching the type allow the pattern to match a constant value of the same type? If so, that would be a functional change. I think it would be mostly positive (less move-const-to-register for constants that may be used directly), but I vaguely recall that I did see ptxas not accepting constants/symbols as an argument for some instructions and required moving them into a register first.

I don't think we have robust enough test coverage for that. I'm OK with the patch, but keep an eye on it after it lands, in case it breaks something. It should be easy to undo the change for the affected instructions, if we find any.

https://github.com/llvm/llvm-project/pull/120161