[llvm] [memprof] Undrift MemProfRecord (PR #120138)

Snehasish Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 13:36:42 PST 2024


================
@@ -171,6 +171,10 @@ static cl::opt<std::string>
                                  cl::desc("The default memprof options"),
                                  cl::Hidden, cl::init(""));
 
+static cl::opt<bool> UndriftProfile("memprof-undrift-profile",
----------------
snehasish wrote:

Can you change this flag to include "stale-profile" in the name so that it's easier to find related work in the LLVM code base? For example, we have "salvage-stale-profile" (for Sample PGO) and "infer-stale-profile" for BOLT. This flag could be "memprof-salvage-stale-profile" or something similar. Wdyt?

Also undrift is not a well known term in LLVM (all the references are in MemProf) so we should spell out what we mean in the description.

https://github.com/llvm/llvm-project/pull/120138


More information about the llvm-commits mailing list