[llvm] [llvm]Add a simple Telemetry framework (PR #102323)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 01:28:14 PST 2024


================
@@ -27,21 +27,20 @@ namespace telemetry {
 
 class Serializer {
 public:
-  virtual llvm::Error start() = 0;
-  virtual void writeBool(StringRef KeyName, bool Value) = 0;
-  virtual void writeInt32(StringRef KeyName, int Value) = 0;
-  virtual void writeSizeT(StringRef KeyName, size_t Value) = 0;
-  virtual void writeString(StringRef KeyName, StringRef Value) = 0;
-  virtual void
-  writeKeyValueMap(StringRef KeyName,
-                   const std::map<std::string, std::string> &Value) = 0;
-  virtual llvm::Error finish() = 0;
+  virtual llvm::Error init() = 0;
+  virtual void write(StringRef KeyName, bool Value) = 0;
+  virtual void write(StringRef KeyName, int Value) = 0;
+  virtual void write(StringRef KeyName, size_t Value) = 0;
+  virtual void write(StringRef KeyName, StringRef Value) = 0;
+  virtual void write(StringRef KeyName,
+                     const std::map<std::string, std::string> &Value) = 0;
+  virtual llvm::Error finalize() = 0;
----------------
jh7370 wrote:

```suggestion
  virtual Error finalize() = 0;
```

https://github.com/llvm/llvm-project/pull/102323


More information about the llvm-commits mailing list