[llvm] [Offload][AMDGPU] accept generic target (PR #118919)

Shilei Tian via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 20:07:04 PST 2024


================
@@ -190,8 +190,9 @@ Error asyncMemCopy(bool UseMultipleSdmaEngines, void *Dst, hsa_agent_t DstAgent,
 #endif
 }
 
-Expected<std::string> getTargetTripleAndFeatures(hsa_agent_t Agent) {
-  std::string Target;
+Expected<StringRef>
+getTargetTripleAndFeatures(hsa_agent_t Agent, SmallVector<StringRef> &Targets) {
+  StringRef SpecificTarget;
----------------
shiltian wrote:

I'm confused here. Why do we need to care about a "specific" target vs. (potentially) non-specific ones stored in `Targets`, instead of just having them all in `Targets` and then just iterate through it?

https://github.com/llvm/llvm-project/pull/118919


More information about the llvm-commits mailing list