[llvm] [AMDGPU] Fix hidden kernarg preload count inconsistency (PR #116759)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 13:31:57 PST 2024


================
@@ -520,6 +520,16 @@ bool AMDGPUCallLowering::lowerFormalArgumentsKernel(
 
   // TODO: Align down to dword alignment and extract bits for extending loads.
   for (auto &Arg : F.args()) {
+    // Hidden arguments that are in the kernel signature must be preloaded to
+    // user SGPRs. Print a diagnostic error if a hidden argument is in the
+    // argument list and is not preloaded.
+    if (Arg.hasAttribute("amdgpu-hidden-argument")) {
+      DiagnosticInfoUnsupported NonPreloadHiddenArg(
+          *Arg.getParent(),
+          "hidden argument in kernel signature was not preloaded");
+      F.getContext().diagnose(NonPreloadHiddenArg);
----------------
arsenm wrote:

return false and comment (with debug print) this is just because it's not implemented in globalisel 

https://github.com/llvm/llvm-project/pull/116759


More information about the llvm-commits mailing list