[lld] [lld][MachO] rename to bp-* options for SectionOrderer (PR #118594)

Ellis Hoag via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 10:01:08 PST 2024


================
@@ -353,14 +353,16 @@ void macho::PriorityBuilder::parseOrderFile(StringRef path) {
 DenseMap<const InputSection *, size_t>
 macho::PriorityBuilder::buildInputSectionPriorities() {
   DenseMap<const InputSection *, size_t> sectionPriorities;
-  if (!config->irpgoProfileSortProfilePath.empty() ||
-      config->functionOrderForCompression || config->dataOrderForCompression) {
+  if (!config->irpgoProfilePath.empty() ||
+      config->bpFunctionOrderForCompression ||
+      config->bpDataOrderForCompression) {
     TimeTraceScope timeScope("Balanced Partitioning Section Orderer");
     sectionPriorities = runBalancedPartitioning(
-        highestAvailablePriority, config->irpgoProfileSortProfilePath,
-        config->functionOrderForCompression, config->dataOrderForCompression,
-        config->compressionSortStartupFunctions,
-        config->verboseBpSectionOrderer);
+        highestAvailablePriority, config->irpgoProfilePath,
----------------
ellishg wrote:

This way we will only order startup functions if `bp-startup-sort=function` is specified
```suggestion
        highestAvailablePriority, config->bpStartupFunctionSort ? config->irpgoProfilePath : "",
```

https://github.com/llvm/llvm-project/pull/118594


More information about the llvm-commits mailing list