[llvm] [llvm][Support][Windows] Avoid crash calling remove_directories() (PR #118677)

Pavel Labath via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 00:26:43 PST 2024


labath wrote:

> The only thing we know for sure is that the crash occured in SHELL32_CallFileCopyHooks(),

Yes, but I don't think that's a sufficient reason to make this change.

> which is not needed for this operation. By disabling CopyHooks we will increase performance and improve stability in any case.

This might be a sufficient reason, if true, which simply just don't know. @mstorsjo, what do you make of this?

https://github.com/llvm/llvm-project/pull/118677


More information about the llvm-commits mailing list