[llvm] [Offload][AMDGPU] accept generic target (PR #118919)

via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 20:38:20 PST 2024


================
@@ -205,13 +205,16 @@ Expected<std::string> getTargetTripleAndFeatures(hsa_agent_t Agent) {
       return Status;
 
     llvm::StringRef TripleTarget(ISAName.begin(), Length);
-    if (TripleTarget.consume_front("amdgcn-amd-amdhsa"))
-      Target = TripleTarget.ltrim('-').rtrim('\0').str();
-    return HSA_STATUS_INFO_BREAK;
+    if (TripleTarget.consume_front("amdgcn-amd-amdhsa")) {
+      auto Target = TripleTarget.ltrim('-').rtrim('\0').str();
+      if (Target.find("generic") != std::string::npos)
----------------
hidekisaito wrote:

That's why Targets[0] is reserved to obtain the specific ISA anywhere in the HSA enumeration, but I agree that wasn't a clean coding. Should I just use a vector class that supports push_front() instead of SmallVector?

https://github.com/llvm/llvm-project/pull/118919


More information about the llvm-commits mailing list