[llvm] Bump minimum MSVC version by one dot release to VS 2019 16.8 (PR #118833)

[Chandler Carruth via llvm-commits]

https://github.com/chandlerc created https://github.com/llvm/llvm-project/pull/118833

This is a small change, but unblocks using longer string literals in LLVM's source code, and hopefully isn't disruptive.

Discussed in an RFC here: https://discourse.llvm.org/t/rfc-raising-minimum-msvc-version-by-one-dot-release/

>From 6a07836aa440f455ebf6b5936c9771c91e7013d7 Mon Sep 17 00:00:00 2001
From: Chandler Carruth <chandlerc at gmail.com>
Date: Thu, 5 Dec 2024 03:43:15 +0000
Subject: [PATCH] Bump minimum MSVC version by one dot release to VS 2019 16.8

This is a small change, but unblocks using longer string literals in
LLVM's source code, and hopefully isn't disruptive.

Discussed in an RFC here: https://discourse.llvm.org/t/rfc-raising-minimum-msvc-version-by-one-dot-release/
---
 llvm/cmake/modules/CheckCompilerVersion.cmake | 6 +++---
 llvm/docs/GettingStarted.rst                  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/llvm/cmake/modules/CheckCompilerVersion.cmake b/llvm/cmake/modules/CheckCompilerVersion.cmake
index 4b3a0eb9a44330..c550df7b08c844 100644
--- a/llvm/cmake/modules/CheckCompilerVersion.cmake
+++ b/llvm/cmake/modules/CheckCompilerVersion.cmake
@@ -12,9 +12,9 @@ set(APPLECLANG_MIN 10.0)
 set(APPLECLANG_SOFT_ERROR 10.0)
 
 # https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering
-# _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7
-set(MSVC_MIN 19.27)
-set(MSVC_SOFT_ERROR 19.27)
+# _MSC_VER == 1928 MSVC++ 19.27 Visual Studio 2019 Version 16.8 + 16.9
+set(MSVC_MIN 19.28)
+set(MSVC_SOFT_ERROR 19.28)
 
 set(LIBSTDCXX_MIN 7)
 set(LIBSTDCXX_SOFT_ERROR 7)
diff --git a/llvm/docs/GettingStarted.rst b/llvm/docs/GettingStarted.rst
index 8ef1f85d6b6fd7..7f4b62f63957b4 100644
--- a/llvm/docs/GettingStarted.rst
+++ b/llvm/docs/GettingStarted.rst
@@ -356,7 +356,7 @@ popular host toolchains for specific minimum versions in our build systems:
 * Clang 5.0
 * Apple Clang 10.0
 * GCC 7.4
-* Visual Studio 2019 16.7
+* Visual Studio 2019 16.8
 
 Anything older than these toolchains *may* work, but will require forcing the
 build system with a special option and is not really a supported host platform.