[llvm] [llvm][Support][Windows] Avoid crash calling remove_directories() (PR #118677)
Pavel Labath via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 5 00:50:33 PST 2024
https://github.com/labath commented:
I don't really feel qualified to review this, so take this with a large grain of salt, but my thoughts are:
- I'm not convinced that this is the same problem as in the referenced article. Unlike the article, where the crash was in some third party extension, this appears to be a built-in OS component which (I would hope) doesn't have these kinds of bugs. I'm not saying we shouldn't suppress these hooks (this ties into the second point), but I'm not sure that this will actually resolve the underlying issue (which could be some sort of corruption/race in lldb/llvm which manifests as a crash in this place).
- is there any advantage in doing this instead of the "manual" iterate-over-subdirectories approach (which is what the unix version of this does)? If not, we could probably even share code with that impl. I'm asking this because `SHFileOperationW` sounds like its meant for a shell, and we're not trying to be a shell -- we just want to make a directory disappear.
https://github.com/llvm/llvm-project/pull/118677
More information about the llvm-commits
mailing list