[llvm] SimplifyLibCalls: Use the correct address space when computing integer widths. (PR #118586)

[Owen Anderson via llvm-commits]

================
@@ -590,26 +588,35 @@ Value *LibCallSimplifier::optimizeStrCmp(CallInst *CI, IRBuilderBase &B) {
   if (Len1 && Len2) {
     return copyFlags(
         *CI, emitMemCmp(Str1P, Str2P,
-                        ConstantInt::get(DL.getIntPtrType(CI->getContext()),
-                                         std::min(Len1, Len2)),
+                        ConstantInt::get(
+                            DL.getIntPtrType(
+                                CI->getContext(),
+                                Str1P->getType()->getPointerAddressSpace()),
+                            std::min(Len1, Len2)),
----------------
resistor wrote:

Would you be amenable to moving `getSizeTSize()` onto `DataLayout`? That would make it much easier to update all callers of `CreateMemCpy`.

I'll look at ensuring `getSizeTSize()` is correct for CHERI targets in a separate PR.

https://github.com/llvm/llvm-project/pull/118586