[llvm] SimplifyLibCalls: Use the correct address space when computing integer widths. (PR #118586)

[Eli Friedman via llvm-commits]

================
@@ -3357,7 +3362,9 @@ Value *LibCallSimplifier::optimizePrintFString(CallInst *CI, IRBuilderBase &B) {
     // Create a string literal with no \n on it.  We expect the constant merge
     // pass to be run after this pass, to merge duplicate strings.
     FormatStr = FormatStr.drop_back();
-    Value *GV = B.CreateGlobalString(FormatStr, "str");
+    Value *GV = B.CreateGlobalString(
+        FormatStr, "str",
+        CI->getArgOperand(0)->getType()->getPointerAddressSpace());
----------------
efriedma-quic wrote:

If you're going to touch CreateGlobalString, please fix all the calls in this file at the same time.

On targets with multiple address-spaces, is it actually legal to create a global like this?  I thought the usual convention was to create a global in some specific address-space, then addrspacecast it to the correct address-space.

https://github.com/llvm/llvm-project/pull/118586