[lld] [lld][ELF][MachO] rename to bp-* options for SectionOrderer (PR #118594)

Ellis Hoag via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 11:09:45 PST 2024


================
@@ -126,17 +126,17 @@ def no_call_graph_profile_sort : Flag<["--"], "no-call-graph-profile-sort">,
 def print_symbol_order_eq: Joined<["--"], "print-symbol-order=">,
     HelpText<"Print a symbol order specified by --call-graph-profile-sort into the specified file">,
     Group<grp_lld>;
-def irpgo_profile_sort: Separate<["--"], "irpgo-profile-sort">, Group<grp_lld>;
-def irpgo_profile_sort_eq: Joined<["--"], "irpgo-profile-sort=">,
-    Alias<!cast<Separate>(irpgo_profile_sort)>, MetaVarName<"<profile>">,
+def irpgo_profile: Separate<["--"], "irpgo-profile">, Group<grp_lld>;
+def irpgo_profile_eq: Joined<["--"], "irpgo-profile=">,
+    Alias<!cast<Separate>(irpgo_profile)>, MetaVarName<"<profile>">,
----------------
ellishg wrote:

>From @mysterymath's [comment](https://github.com/llvm/llvm-project/pull/117514#discussion_r1861155463), I think we should have `-irpgo-profile=` as a general flag to consume a profile and then a separate `-bp-startup-sort={none,function}` (with `data`, and `both` to come later) to specify how we want to use this profile. That opens up the possibility of a flag like `-hot-function-region` for a different way to use this profile.

https://github.com/llvm/llvm-project/pull/118594


More information about the llvm-commits mailing list