[llvm] [SystemZ] SIMM32 is a signed constant (PR #118634)

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 09:33:56 PST 2024


================
@@ -262,8 +262,8 @@ def UIMM16 : SDNodeXForm<imm, [{
 
 // Truncate an immediate to a 32-bit signed quantity.
 def SIMM32 : SDNodeXForm<imm, [{
-  return CurDAG->getTargetConstant(int32_t(N->getZExtValue()), SDLoc(N),
-                                   MVT::i64);
+  return CurDAG->getSignedTargetConstant(int32_t(N->getZExtValue()), SDLoc(N),
----------------
uweigand wrote:

Good point.  This should be done for all the SIMM variants then, I think.  @redstar would you mind doing this in a follow-on PR?

https://github.com/llvm/llvm-project/pull/118634


More information about the llvm-commits mailing list