[llvm] [LAA] Strip non-inbounds offset in getPointerDiff() (NFC) (PR #118665)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 4 08:26:33 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-analysis
Author: Nikita Popov (nikic)
<details>
<summary>Changes</summary>
I believe that this code doesn't care whether the offsets are known to be inbounds a priori. For the same reason the change is not testable, as the SCEV based fallback code will look through non-inbounds offsets anyway. So make it clear that there is no special inbounds requirement here.
---
Full diff: https://github.com/llvm/llvm-project/pull/118665.diff
1 Files Affected:
- (modified) llvm/lib/Analysis/LoopAccessAnalysis.cpp (+4-4)
``````````diff
diff --git a/llvm/lib/Analysis/LoopAccessAnalysis.cpp b/llvm/lib/Analysis/LoopAccessAnalysis.cpp
index 71582d5d86549b..2c75d5625cb66d 100644
--- a/llvm/lib/Analysis/LoopAccessAnalysis.cpp
+++ b/llvm/lib/Analysis/LoopAccessAnalysis.cpp
@@ -1566,10 +1566,10 @@ std::optional<int> llvm::getPointersDiff(Type *ElemTyA, Value *PtrA,
unsigned IdxWidth = DL.getIndexSizeInBits(ASA);
APInt OffsetA(IdxWidth, 0), OffsetB(IdxWidth, 0);
- const Value *PtrA1 =
- PtrA->stripAndAccumulateInBoundsConstantOffsets(DL, OffsetA);
- const Value *PtrB1 =
- PtrB->stripAndAccumulateInBoundsConstantOffsets(DL, OffsetB);
+ const Value *PtrA1 = PtrA->stripAndAccumulateConstantOffsets(
+ DL, OffsetA, /*AllowNonInbounds=*/true);
+ const Value *PtrB1 = PtrB->stripAndAccumulateConstantOffsets(
+ DL, OffsetB, /*AllowNonInbounds=*/true);
int Val;
if (PtrA1 == PtrB1) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/118665
More information about the llvm-commits
mailing list