[llvm] Reland "[ObjectYAML][ELF] Take alignment into account when generating notes" (PR #118434)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 08:04:30 PST 2024


================
@@ -1810,7 +1810,7 @@ void ELFState<ELFT>::writeSectionContent(Elf_Shdr &SHeader,
     break;
   default:
     reportError(Section.Name + ": invalid alignment for a note section: 0x" +
-                Twine::utohexstr(SHeader.sh_addralign));
+                Twine::utohexstr(Section.AddressAlign));
----------------
jh7370 wrote:

Sorry, I posted this comment in the wrong place by accident, so it might be confusing things a little. I actually was referring to the switch a bit above, not specifically the error message. In other words, showing that if `ShAddrAlign: 4` is specified but `AddressAlign: 8` is specified, the 8 is used for padding purposes. In other words, catching the problem I pointed out earlier and that got changed.

https://github.com/llvm/llvm-project/pull/118434


More information about the llvm-commits mailing list