[llvm] AMDGPU: Add MC support for gfx950 V_BITOP3_B32/B16 (PR #117379)

Mikael Holmén via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 02:31:00 PST 2024


================
@@ -9748,6 +9759,20 @@ ParseStatus AMDGPUAsmParser::parseEndpgm(OperandVector &Operands) {
 
 bool AMDGPUOperand::isEndpgm() const { return isImmTy(ImmTyEndpgm); }
 
+//===----------------------------------------------------------------------===//
+// BITOP3
+//===----------------------------------------------------------------------===//
+
+ParseStatus AMDGPUAsmParser::parseBitOp3(OperandVector &Operands) {
+  ParseStatus Res =
+      parseIntWithPrefix("bitop3", Operands, AMDGPUOperand::ImmTyBitOp3);
+  return Res;
+}
+
+AMDGPUOperand::Ptr AMDGPUAsmParser::defaultBitOp3() const {
----------------
mikaelholmen wrote:

Hi,

This method seems to be unused on main. WIll it be used in some coming patch or should it be removed?
gcc warns like
```
../lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:9809: warning: '{anonymous}::AMDGPUOperand::Ptr {anonymous}::AMDGPUAsmParser::defaultBitOp3() const' defined but not used [-Wunused-function]
 9809 | AMDGPUOperand::Ptr AMDGPUAsmParser::defaultBitOp3() const {
      | 
```

https://github.com/llvm/llvm-project/pull/117379


More information about the llvm-commits mailing list