[llvm] [InstCombine] Simplify `add nsw/nuw i1` to `or disjoint i1` (PR #118221)

Yingwei Zheng via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 17:27:28 PST 2024


dtcxzyw wrote:

> Hey @dtcxzyw. This is one of my first contributions to LLVM. What kind of tests do you mean by "_tests to demonstrate that this change will improve the final codegen/analysis results_"?

Please refer to https://llvm.org/docs/InstCombineContributorGuide.html#real-world-usefulness. Since this pattern is rare, you should add some tests to show that this patch is important.

cc @scottmcm Does this patch improve Rust codegen?



https://github.com/llvm/llvm-project/pull/118221


More information about the llvm-commits mailing list