[llvm] Add symbol visibility macros to abi-breaking.h.cmake (PR #110898)

Julian Nagele via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 09:19:07 PST 2024


juliannagele wrote:

> > > > We should probably make Compiler.h textual.
> > > 
> > > 
> > > Was that tried, @juliannagele?
> > 
> > 
> > I wouldn't know I'm afraid, happy to give it a try if you have a patch.
> 
> ```diff
> diff --git a/llvm/include/module.modulemap b/llvm/include/module.modulemap
> index b00da6d7cd28..0c05e4cf674d 100644
> --- a/llvm/include/module.modulemap
> +++ b/llvm/include/module.modulemap
> @@ -389,7 +389,7 @@ module LLVM_Utils {
>      exclude header "llvm/Support/PluginLoader.h"
>      exclude header "llvm/Support/Solaris/sys/regset.h"
>      textual header "llvm/Support/TargetOpcodes.def"
> -
> +    textual header "llvm/Support/Compiler.h"
>    }
>  
>    module TargetParser {
> ```

Thanks, afaict that would fix the cyclic dependency (then exposing another issue that looks unrelated).

https://github.com/llvm/llvm-project/pull/110898


More information about the llvm-commits mailing list