[llvm] 4dafb09 - Revert "Add symbol visibility macros to abi-breaking.h.cmake" (#118464)

via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 02:28:16 PST 2024


Author: Julian Nagele
Date: 2024-12-03T10:28:12Z
New Revision: 4dafb091a0336a6669e6369cb69ef1ea1b39578d

URL: https://github.com/llvm/llvm-project/commit/4dafb091a0336a6669e6369cb69ef1ea1b39578d
DIFF: https://github.com/llvm/llvm-project/commit/4dafb091a0336a6669e6369cb69ef1ea1b39578d.diff

LOG: Revert "Add symbol visibility macros to abi-breaking.h.cmake" (#118464)

Reverts llvm/llvm-project#110898

This change has caused a cyclic module dependency `fatal error: cyclic
dependency in module 'LLVM_Utils': LLVM_Utils ->
LLVM_Config_ABI_Breaking -> LLVM_Utils`. Reverting for now until we the
right fix.

Added: 
    

Modified: 
    llvm/include/llvm/Config/abi-breaking.h.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Config/abi-breaking.h.cmake b/llvm/include/llvm/Config/abi-breaking.h.cmake
index 81495f0569752c..2d27e02b1d5457 100644
--- a/llvm/include/llvm/Config/abi-breaking.h.cmake
+++ b/llvm/include/llvm/Config/abi-breaking.h.cmake
@@ -12,8 +12,6 @@
 #ifndef LLVM_ABI_BREAKING_CHECKS_H
 #define LLVM_ABI_BREAKING_CHECKS_H
 
-#include "llvm/Support/Compiler.h"
-
 /* Define to enable checks that alter the LLVM C++ ABI */
 #cmakedefine01 LLVM_ENABLE_ABI_BREAKING_CHECKS
 
@@ -45,12 +43,12 @@
 #endif
 namespace llvm {
 #if LLVM_ENABLE_ABI_BREAKING_CHECKS
-LLVM_ABI extern int EnableABIBreakingChecks;
+extern int EnableABIBreakingChecks;
 LLVM_HIDDEN_VISIBILITY
 __attribute__((weak)) int *VerifyEnableABIBreakingChecks =
     &EnableABIBreakingChecks;
 #else
-LLVM_ABI extern int DisableABIBreakingChecks;
+extern int DisableABIBreakingChecks;
 LLVM_HIDDEN_VISIBILITY
 __attribute__((weak)) int *VerifyDisableABIBreakingChecks =
     &DisableABIBreakingChecks;


        


More information about the llvm-commits mailing list