[llvm] Revert "Add symbol visibility macros to abi-breaking.h.cmake" (PR #118464)
Julian Nagele via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 3 02:27:52 PST 2024
https://github.com/juliannagele created https://github.com/llvm/llvm-project/pull/118464
Reverts llvm/llvm-project#110898
This change has caused a cyclic module dependency `fatal error: cyclic dependency in module 'LLVM_Utils': LLVM_Utils -> LLVM_Config_ABI_Breaking -> LLVM_Utils`. Reverting for now until we the right fix.
>From 4bac5f9cec8e73b14c5cfa0dd6d9c3656ea2cdd5 Mon Sep 17 00:00:00 2001
From: Julian Nagele <j.nagele at apple.com>
Date: Tue, 3 Dec 2024 10:24:06 +0000
Subject: [PATCH] Revert "Add symbol visibility macros to abi-breaking.h.cmake
(#110898)"
This reverts commit 3be691651a2143f23bcf8f2704e55b01bbaa2550.
---
llvm/include/llvm/Config/abi-breaking.h.cmake | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/llvm/include/llvm/Config/abi-breaking.h.cmake b/llvm/include/llvm/Config/abi-breaking.h.cmake
index 81495f0569752c..2d27e02b1d5457 100644
--- a/llvm/include/llvm/Config/abi-breaking.h.cmake
+++ b/llvm/include/llvm/Config/abi-breaking.h.cmake
@@ -12,8 +12,6 @@
#ifndef LLVM_ABI_BREAKING_CHECKS_H
#define LLVM_ABI_BREAKING_CHECKS_H
-#include "llvm/Support/Compiler.h"
-
/* Define to enable checks that alter the LLVM C++ ABI */
#cmakedefine01 LLVM_ENABLE_ABI_BREAKING_CHECKS
@@ -45,12 +43,12 @@
#endif
namespace llvm {
#if LLVM_ENABLE_ABI_BREAKING_CHECKS
-LLVM_ABI extern int EnableABIBreakingChecks;
+extern int EnableABIBreakingChecks;
LLVM_HIDDEN_VISIBILITY
__attribute__((weak)) int *VerifyEnableABIBreakingChecks =
&EnableABIBreakingChecks;
#else
-LLVM_ABI extern int DisableABIBreakingChecks;
+extern int DisableABIBreakingChecks;
LLVM_HIDDEN_VISIBILITY
__attribute__((weak)) int *VerifyDisableABIBreakingChecks =
&DisableABIBreakingChecks;
More information about the llvm-commits
mailing list