[llvm] Move a lot of symbol code to use the symbol string pool (PR #115796)

[Lang Hames via llvm-commits]

================
@@ -486,7 +486,7 @@ class MissingSymbolDefinitions : public ErrorInfo<MissingSymbolDefinitions> {
 
   MissingSymbolDefinitions(std::shared_ptr<SymbolStringPool> SSP,
                            std::string ModuleName, SymbolNameVector Symbols)
-      : SSP(std::move(SSP)), ModuleName(std::move(ModuleName)),
+      : SSP(SSP), ModuleName(std::move(ModuleName)),
----------------
lhames wrote:

This `std::move` should be safe to keep?

https://github.com/llvm/llvm-project/pull/115796