[llvm] Move a lot of symbol code to use the symbol string pool (PR #115796)

[Lang Hames via llvm-commits]

================
@@ -354,9 +354,11 @@ RewriteInstance::RewriteInstance(ELFObjectFileBase *File, const int Argc,
     }
   }
 
+  auto SSP = std::make_shared<orc::SymbolStringPool>();
+
   Relocation::Arch = TheTriple.getArch();
   auto BCOrErr = BinaryContext::createBinaryContext(
-      TheTriple, File->getFileName(), Features.get(), IsPIC,
+      TheTriple, SSP, File->getFileName(), Features.get(), IsPIC,
----------------
lhames wrote:

I wouldn't name this unless it's going to be used below. Instead I'd construct it directly in the argument list:

```c++
TheTriple, std::make_shared<orc::SymbolStringPool>(), File->getFileName(), ...
```


https://github.com/llvm/llvm-project/pull/115796