[compiler-rt] 877b934 - [CompilerRT] Remove sanitizer support for i386 watchsim (#117013)

via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 19:34:29 PST 2024


Author: Cyndy Ishida
Date: 2024-12-02T19:34:25-08:00
New Revision: 877b934831d491e4388b82794cded417b1b11862

URL: https://github.com/llvm/llvm-project/commit/877b934831d491e4388b82794cded417b1b11862
DIFF: https://github.com/llvm/llvm-project/commit/877b934831d491e4388b82794cded417b1b11862.diff

LOG: [CompilerRT] Remove sanitizer support for i386 watchsim (#117013)

This patch removes remaining support for i386 simulators, watch was the
only one left though.

resolves: rdar://102741146

Added: 
    

Modified: 
    compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

Removed: 
    


################################################################################
diff  --git a/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake b/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
index f3c8fbe2c2fecd..74a5d4edcd859f 100644
--- a/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
+++ b/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
@@ -136,14 +136,13 @@ function(darwin_test_archs os valid_archs)
 
   # The simple program will build for x86_64h on the simulator because it is
   # compatible with x86_64 libraries (mostly), but since x86_64h isn't actually
-  # a valid or useful architecture for the iOS simulator we should drop it.
+  # a valid or useful architecture for the simulators. We should drop it.
   if(${os} MATCHES "^(iossim|tvossim|watchossim)$")
     list(REMOVE_ITEM archs "x86_64h")
-  endif()
-
-  if(${os} MATCHES "iossim")
-    message(STATUS "Disabling i386 slice for iossim")
-    list(REMOVE_ITEM archs "i386")
+    if ("i386" IN_LIST archs)
+      list(REMOVE_ITEM archs "i386")
+      message(STATUS "Disabling i386 slice for simulator")
+    endif()
   endif()
 
   if(${os} MATCHES "^ios$")


        


More information about the llvm-commits mailing list