[lld] [LLD] [COFF] Print a warning when using /dependentloadflag without load config (PR #117400)

Mon Dec 2 08:24:39 PST 2024

mati865 wrote:

> Sorry for the late reply.

No problem.

> I'm still hesitant about the positioning of the check.

I don't mind either way, I'm going to change it.

> I also want to point out that
> 
> https://github.com/llvm/llvm-project/blob/3a31427224d4fa49d7ef737b21f6027dc4928ecf/lld/COFF/Writer.cpp#L2634-L2635
> > 
> 
> 
> only sets the `DependentLoadFlags` field of `_load_config_used` if it is set to a non-zero value.

I think it has nothing to do with this PR unless I missed something obvious. I'm not going to look into it.

> One more note that is not strictly related to this PR

Likewise, I'm not going to look into it.

> (It probably just needs a `.p2align 3` before the start of the struct.)

I have tried that and several other ways I could find, but the warning wouldn't go away.

https://github.com/llvm/llvm-project/pull/117400