[compiler-rt] [llvm] [X86][compiler-rt] Split CPU names even they have the same subtype (PR #118237)

Phoebe Wang via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 1 22:13:39 PST 2024


phoebewang wrote:

> `llvm/lib/TargetParser/Host.cpp` needs to be updated as well and is probably what is causing the linked issue.
> 
> As a side note, can I get some reviews on my PRs to test/merge this infra between compiler-rt and LLVM?
> 
> 1. [[compiler-rt][X86] Unify getIntelProcessorTypeAndSubtype #97861](https://github.com/llvm/llvm-project/pull/97861)
> 2. [[compiler-rt][X86] Better unify ProcessorFeatures and X86TargetParser #97856](https://github.com/llvm/llvm-project/pull/97856)
> 3. [[compiler-rt][X86] Unify getAvailableFeatures #97872](https://github.com/llvm/llvm-project/pull/97872) (probably not ready for review yet).
> 4. [[compiler-rt] Add infrastructure for testing cpuid builtins #101927](https://github.com/llvm/llvm-project/pull/101927)
> 
> That will make changes like this in the future easier.

Good catch, thanks! I have a few comments on them, but I don't see how they guarantee synchronization between compiler and compiler-rt. Plus, how to sync with different libgcc?

https://github.com/llvm/llvm-project/pull/118237


More information about the llvm-commits mailing list