[llvm] 574f64c - [TimeProfiler] Remove unneeded check

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 1 15:13:02 PST 2024


Author: Fangrui Song
Date: 2024-12-01T15:12:57-08:00
New Revision: 574f64ca61d252dbcf98621e056ab02b93d928bc

URL: https://github.com/llvm/llvm-project/commit/574f64ca61d252dbcf98621e056ab02b93d928bc
DIFF: https://github.com/llvm/llvm-project/commit/574f64ca61d252dbcf98621e056ab02b93d928bc.diff

LOG: [TimeProfiler] Remove unneeded check

Added: 
    

Modified: 
    llvm/include/llvm/Support/TimeProfiler.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/TimeProfiler.h b/llvm/include/llvm/Support/TimeProfiler.h
index 8c0ecf9b7c911f..679e157f3dfd82 100644
--- a/llvm/include/llvm/Support/TimeProfiler.h
+++ b/llvm/include/llvm/Support/TimeProfiler.h
@@ -185,25 +185,17 @@ class TimeTraceScope {
   TimeTraceScope(TimeTraceScope &&) = delete;
   TimeTraceScope &operator=(TimeTraceScope &&) = delete;
 
-  TimeTraceScope(StringRef Name) {
-    if (getTimeTraceProfilerInstance() != nullptr)
-      Entry = timeTraceProfilerBegin(Name, StringRef(""));
-  }
-  TimeTraceScope(StringRef Name, StringRef Detail) {
-    if (getTimeTraceProfilerInstance() != nullptr)
-      Entry = timeTraceProfilerBegin(Name, Detail);
-  }
-  TimeTraceScope(StringRef Name, llvm::function_ref<std::string()> Detail) {
-    if (getTimeTraceProfilerInstance() != nullptr)
-      Entry = timeTraceProfilerBegin(Name, Detail);
-  }
+  TimeTraceScope(StringRef Name)
+      : Entry(timeTraceProfilerBegin(Name, StringRef())) {}
+  TimeTraceScope(StringRef Name, StringRef Detail)
+      : Entry(timeTraceProfilerBegin(Name, Detail)) {}
+  TimeTraceScope(StringRef Name, llvm::function_ref<std::string()> Detail)
+      : Entry(timeTraceProfilerBegin(Name, Detail)) {}
   TimeTraceScope(StringRef Name,
-                 llvm::function_ref<TimeTraceMetadata()> Metadata) {
-    if (getTimeTraceProfilerInstance() != nullptr)
-      Entry = timeTraceProfilerBegin(Name, Metadata);
-  }
+                 llvm::function_ref<TimeTraceMetadata()> Metadata)
+      : Entry(timeTraceProfilerBegin(Name, Metadata)) {}
   ~TimeTraceScope() {
-    if (getTimeTraceProfilerInstance() != nullptr)
+    if (Entry)
       timeTraceProfilerEnd(Entry);
   }
 


        


More information about the llvm-commits mailing list