[llvm] [AArch64][SVE] Add partial reduction SDNodes (PR #117185)

Benjamin Maxwell via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 29 03:21:32 PST 2024


================
@@ -1595,10 +1595,11 @@ class SelectionDAG {
   /// the target's desired shift amount type.
   SDValue getShiftAmountOperand(EVT LHSTy, SDValue Op);
 
-  /// Create the DAG equivalent of vector_partial_reduce where Op1 and Op2 are
-  /// its operands and ReducedTY is the intrinsic's return type.
-  SDValue getPartialReduceAdd(SDLoc DL, EVT ReducedTy, SDValue Op1,
-                              SDValue Op2);
+  /// Expands PARTIAL_REDUCE_ADD nodes which can't be lowered.
----------------
MacDue wrote:

nit: I don't think "which can't be lowered" is relevant to this function, I think it's better to say what the function does. Maybe something "Expands PARTIAL_REDUCE_ADD nodes to a sequence of subvector extracts followed by vector adds"

https://github.com/llvm/llvm-project/pull/117185


More information about the llvm-commits mailing list