[llvm] [Bolt][PVS] Fix passing incorrect argument as default to isStoreUsed (PR #118040)

via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 28 16:37:15 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-bolt

Author: None (AlexErofeev)

<details>
<summary>Changes</summary>

Fixes first issue out listed in #<!-- -->116944 
Given number of times this method is called, maybe it would make sense to force specifying this parameters explicitly?

---
Full diff: https://github.com/llvm/llvm-project/pull/118040.diff


1 Files Affected:

- (modified) bolt/lib/Passes/ShrinkWrapping.cpp (+2-2) 


``````````diff
diff --git a/bolt/lib/Passes/ShrinkWrapping.cpp b/bolt/lib/Passes/ShrinkWrapping.cpp
index 176321c58dc903..bc4e7e6e386a0e 100644
--- a/bolt/lib/Passes/ShrinkWrapping.cpp
+++ b/bolt/lib/Passes/ShrinkWrapping.cpp
@@ -78,8 +78,8 @@ void CalleeSavedAnalysis::analyzeSaves() {
         // probably dealing with a parameter passed in a stack -- do not mess
         // with it
         if (SRU.isStoreUsed(*FIE,
-                            Prev ? SRU.expr_begin(*Prev) : SRU.expr_begin(BB)),
-            /*IncludeLocalAccesses=*/false) {
+                            Prev ? SRU.expr_begin(*Prev) : SRU.expr_begin(BB),
+            /*IncludeLocalAccesses=*/false)) {
           BlacklistedRegs.set(FIE->RegOrImm);
           CalleeSaved.reset(FIE->RegOrImm);
           Prev = &Inst;

``````````

</details>


https://github.com/llvm/llvm-project/pull/118040


More information about the llvm-commits mailing list