[llvm] Reapply [BOLT] DataAggregator support for binaries with multiple text segments (PR #118023)
Paschalis Mpeis via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 28 09:17:15 PST 2024
paschalis-mpeis wrote:
## Reapplying:
- #92815
- Originally merged by commit [4b71b37](https://github.com/llvm/llvm-project/commit/4b71b3782d217db0138b701c4514bd2168ca1659), and then reverted by commit [537343d](https://github.com/llvm/llvm-project/commit/537343dea4e65ddb837473c9349884e856664ad8) as it was causing some [local build](https://github.com/llvm/llvm-project/pull/92815#issuecomment-2500868284) failures.
@zmodem, can you confirm by approving this PR that all is OK now?
---
The only change is [this](https://github.com/llvm/llvm-project/pull/118023/commits/71a6c4522ce499fbb201d151f5140c1ae684c5de). An alternative could be to upgrade [this](https://github.com/llvm/llvm-project/blob/71a6c4522ce499fbb201d151f5140c1ae684c5de/bolt/lib/Profile/DataAggregator.cpp#L2132) assertion (line 2132) to a `report_fatal_error`.
@maksfb, let me know if that is preferred, otherwise I will reapply the patch by EOD tomorrow.
https://github.com/llvm/llvm-project/pull/118023
More information about the llvm-commits
mailing list