[llvm] [SLP] NFC. Replace TreeEntry::setOperandsInOrder with VLOperands. (PR #113880)

Alexey Bataev via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 28 08:45:38 PST 2024


alexey-bataev wrote:

> Why do we need to check the ID while the old code does not have to?

Because the load code explicitly worked only for CallInst 

> Because only the commutative intrinsics check it in the old code.

The non-commutative intrinsics also need to have a check for isVectorIntrinsicWithScalarOpAtArg

> I think we should NOT add isVectorIntrinsicWithScalarOpAtArg check for setOperand

The check should be there or this whole patch should be dropped. We should not create pseudo tree node for the scalar instructions

https://github.com/llvm/llvm-project/pull/113880


More information about the llvm-commits mailing list