[llvm] [CodeGen] @llvm.experimental.stackmap make operands immediate (PR #117932)

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 28 03:43:48 PST 2024


uweigand wrote:

I don't have any comments on the actual change, but this part:

>Added new test cases to ensure errors are emitted for non-immediate operands.

doesn't really match the PR - you add several tests, but they are all XFAILed, so they don't check for specific errors.

Usually, to check for a specific error message, you can use the "RUN: not" ... pattern, see e.g. `test/CodeGen/SystemZ/soft-float-inline-asm-01.ll`:
```
; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 -mattr=soft-float -O3 2>&1 | FileCheck %s
; 
; Verify that inline asms cannot use fp/vector registers with soft-float.

define float @f1() {
  %ret = call float asm "", "=f" ()
  ret float %ret
}

; CHECK: error: couldn't allocate output register for constraint 'f'
```


https://github.com/llvm/llvm-project/pull/117932


More information about the llvm-commits mailing list