[llvm] [BOLT][AArch64] Support for pointer authentication (PR #117578)

via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 14:58:02 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 4d8eb009d8ae4500940d77a64d914eed9a13b92c 99cd39495fb74cfa7eebd7bcb678bd40a7f377c4 --extensions cpp,h -- bolt/include/bolt/Passes/InsertNegateRAStatePass.h bolt/lib/Passes/InsertNegateRAStatePass.cpp bolt/include/bolt/Core/BinaryBasicBlock.h bolt/include/bolt/Core/MCPlusBuilder.h bolt/include/bolt/Utils/CommandLineOpts.h bolt/lib/Core/BinaryBasicBlock.cpp bolt/lib/Core/BinaryFunction.cpp bolt/lib/Core/Exceptions.cpp bolt/lib/Passes/BinaryPasses.cpp bolt/lib/Rewrite/BinaryPassManager.cpp bolt/lib/Rewrite/RewriteInstance.cpp bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp bolt/lib/Utils/CommandLineOpts.cpp llvm/include/llvm/ADT/StringRef.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/bolt/include/bolt/Core/MCPlusBuilder.h b/bolt/include/bolt/Core/MCPlusBuilder.h
index 00b69d65a3..937c5c668c 100644
--- a/bolt/include/bolt/Core/MCPlusBuilder.h
+++ b/bolt/include/bolt/Core/MCPlusBuilder.h
@@ -558,7 +558,7 @@ public:
     return CalleeSymbol->getName();
   }
 
-  virtual bool isNoReturnCall(const MCInst& Inst) const {
+  virtual bool isNoReturnCall(const MCInst &Inst) const {
     if (!isCall(Inst))
       return false;
     auto calleeName = getCalleeName(Inst);
diff --git a/bolt/lib/Core/BinaryFunction.cpp b/bolt/lib/Core/BinaryFunction.cpp
index 842a1cb16e..34dd5136f9 100644
--- a/bolt/lib/Core/BinaryFunction.cpp
+++ b/bolt/lib/Core/BinaryFunction.cpp
@@ -2155,7 +2155,8 @@ Error BinaryFunction::buildCFG(MCPlusBuilder::AllocatorIdTy AllocatorId) {
       addCFIPlaceholders(Offset, InsertBB);
     }
 
-    const bool IsBlockEnd = MIB->isTerminator(Instr) || MIB->isNoReturnCall(Instr);
+    const bool IsBlockEnd =
+        MIB->isTerminator(Instr) || MIB->isNoReturnCall(Instr);
     IsLastInstrNop = MIB->isNoop(Instr);
     if (!IsLastInstrNop)
       LastInstrOffset = Offset;
diff --git a/bolt/lib/Rewrite/RewriteInstance.cpp b/bolt/lib/Rewrite/RewriteInstance.cpp
index ce5dc7f10c..5352a6ec8a 100644
--- a/bolt/lib/Rewrite/RewriteInstance.cpp
+++ b/bolt/lib/Rewrite/RewriteInstance.cpp
@@ -2932,7 +2932,8 @@ void RewriteInstance::handleRelocation(const SectionRef &RelocatedSection,
 
 void RewriteInstance::selectFunctionsToProcess() {
   // Extend the list of functions to process or skip from a file.
-  opts::populateFunctionNames(opts::FunctionNamesFile, opts::ForceFunctionNames);
+  opts::populateFunctionNames(opts::FunctionNamesFile,
+                              opts::ForceFunctionNames);
   opts::populateFunctionNames(opts::SkipFunctionNamesFile,
                               opts::SkipFunctionNames);
   opts::populateFunctionNames(opts::FunctionNamesFileNR,
diff --git a/bolt/lib/Utils/CommandLineOpts.cpp b/bolt/lib/Utils/CommandLineOpts.cpp
index 96df4b290b..47f0b9124f 100644
--- a/bolt/lib/Utils/CommandLineOpts.cpp
+++ b/bolt/lib/Utils/CommandLineOpts.cpp
@@ -11,7 +11,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "bolt/Utils/CommandLineOpts.h"
-//#include "VCSVersion.inc"
+// #include "VCSVersion.inc"
 #include "llvm/Support/VCSRevision.h"
 #include <fstream>
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/117578


More information about the llvm-commits mailing list