[flang] [llvm] [Proof-of-Concept][flang][OpenMP] Implicitely map allocatable record fields (PR #117867)

via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 09:43:48 PST 2024


https://github.com/agozillon commented:

This LGTM so far, thank you very much for the work, it looks excellent so far. Left some comments here and there mainly just little notes to hopefully help out / forewarn of certain things :-) 

I think the approach of doing it as an opt/transformation pass is fine personally, and I believe at least Slava from the OpenACC team originally mentioned an approach like this would be ideal for the implicit mapping. The only issue I can see someone bringing up is that we now have a split of implicit mapping between the opt passes and the initial lowering, I personally don't mind though and think it's fine, we can always move the front end lowering down to here at some point if it's a cleaner approach for the implicit mapping and it doesn't hinder anything else. 

https://github.com/llvm/llvm-project/pull/117867


More information about the llvm-commits mailing list